fix(java): log messages may not flush by app exit #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, messages sent by JavaScript using `console.log` and similar may not be completely flushed by the time the Java thread that forwards that data is closed. This is because the thread might not have been given a chance to run when `this.stop` is set to true, which makes it exit immediately. This change adds a new step that triggers once `this.stop` becomes `true` that will flush the `inputStream` until EOF in a blocking way. When this happens, the child process has already been requested to exit, and so EOF should be reached relatively quickly. Fixes #3009
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
rix0rrr
approved these changes
Oct 11, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, messages sent by JavaScript using
console.logandsimilar may not be completely flushed by the time the Java thread that
forwards that data is closed. This is because the thread might not have
been given a chance to run when
this.stopis set to true, which makesit exit immediately.
This change adds a new step that triggers once
this.stopbecomestruethat will flush theinputStreamuntil EOF in a blocking way.When this happens, the child process has already been requested to exit,
and so EOF should be reached relatively quickly.
Fixes #3009
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.