Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify auto approve mechanism #3110

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Nov 2, 2021

Complementary of aws/aws-cdk#17264

Related to https://github.com/cdklabs/cdk-ops/pull/1759


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iliapolo iliapolo changed the title label dependabot PR's with auto-approve chore: simplify auto approve mechanism Nov 2, 2021
@iliapolo iliapolo requested a review from a team November 2, 2021 10:31
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 2, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Nov 2, 2021
@mergify mergify bot merged commit 0386cbe into main Nov 2, 2021
@mergify mergify bot deleted the epolon/add-auto-approve-label-to-dependabot branch November 2, 2021 11:38
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Nov 2, 2021
mergify bot pushed a commit that referenced this pull request Nov 21, 2021
Following #3110, PR's created by `aws-cdk-automation` are no longer automatically approved. Instead, automatic PR's are responsible for adding the `pr/auto-approve` label.

This adds the `pr/auto-approve` label to our upgrade workflow so they are approved and merged automatically. 

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants