Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pacmak): re-introduce parallelism for Python and Go builds #3124

Merged
merged 8 commits into from
Nov 8, 2021
Merged

fix(pacmak): re-introduce parallelism for Python and Go builds #3124

merged 8 commits into from
Nov 8, 2021

Commits on Nov 5, 2021

  1. fix(pacmak): re-introduce parallelism into OneByOneBuilder 

    In #3045, the `OneByOneBuilder` was switched to build all packages
in series (instead of all in parallel), because there would
be race conditions in case of inter-package dependencies.

This is correct, but leaves a bunch of possible parallelism on the
table that is notably blowing up pack times for Python.

Re-introduce a (limited) form of parallelism by retaining the
sets of mutually independent packages, as toposorted, and
doing those in parallel.
    @rix0rrr
    rix0rrr committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    8ae19e6 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @rix0rrr
    rix0rrr committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    22bb14b View commit details
    Browse the repository at this point in the history

  3. Flatten a different way

    @rix0rrr
    rix0rrr committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    5a619a1 View commit details
    Browse the repository at this point in the history

  4. Update index.ts

    @rix0rrr
    rix0rrr authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    ef5e711 View commit details
    Browse the repository at this point in the history

  5. Rename OneByOneBuilder => IndependentPackageBuilder

    @rix0rrr
    rix0rrr committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    7d127c6 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'huijbers/parallel-onebyone' of github.com:awslabs/jsii … 

    …into huijbers/parallel-onebyone
    @rix0rrr
    rix0rrr committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    526c15a View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Fix linter issues

    @rix0rrr
    rix0rrr committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    7e970d8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into huijbers/parallel-onebyone

    @rix0rrr
    rix0rrr authored Nov 8, 2021
    Configuration menu
    Copy the full SHA
    a4e4c8b View commit details
    Browse the repository at this point in the history