chore: stop aliasing typescript in dependencies #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
force-pushed
the
rmuller/vanilla-tsc
branch
from
590a8f4 to
2775769
Compare
iliapolo
approved these changes
Jun 28, 2022
Aliasing `typescript` to `typescript-3.9` results in occasionally surprising hoisting behavior, in particular using `npm 18`. In particular, if two distinct versions of `typescript` are installed, aliasing allows both to be hoisted at the top-level, which results in ambiguity as to which of them gets to have the `node_modules/.bin/tsc` symlink. This PR stops aliasing `typescript` to `typescript-3.9` and does the necessary work to ensure builds continue to operate smoothly, menaing it replaced TypeScript configuration files for jest with plain ESM configuration files including typed JSDoc comments (for IDE supprot to continue working as before), as `jest` otherwise uses `ts-node` to transform the configuration files, and `ts-node` uses the "most local" `typescript` library to perform this parsing (and unfortunately, `typescript@3.9` does not support the `ES2020` target we are using).
RomainMuller
force-pushed
the
rmuller/vanilla-tsc
branch
from
42030dd to
2a0b6bd
Compare
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
1 similar comment
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aliasing
typescripttotypescript-3.9results in occasionallysurprising hoisting behavior, in particular using
npm 18. Inparticular, if two distinct versions of
typescriptare installed,aliasing allows both to be hoisted at the top-level, which results in
ambiguity as to which of them gets to have the
node_modules/.bin/tscsymlink.
This PR stops aliasing
typescripttotypescript-3.9and does thenecessary work to ensure builds continue to operate smoothly, menaing
it replaced TypeScript configuration files for jest with plain ESM
configuration files including typed JSDoc comments (for IDE supprot to
continue working as before), as
jestotherwise usests-nodetotransform the configuration files, and
ts-nodeuses the "most local"typescriptlibrary to perform this parsing (and unfortunately,typescript@3.9does not support theES2020target we are using).This also required allowing
jsii.tsc.typesto be specified in thepackage.jsonfile of jsii projects, as otherwise the TypeScriptcompiler attempts to load
@types/*packages that are not compatiblewith
typescript@3.9(for example,@synclair/typeboxrequirestypescript@>=4.5). This setting is anyway generally useful incomplex monorepo situations.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.