Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(superchain): add 'acl' package to support projen GHA #3783

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

jmalins
Copy link
Contributor

@jmalins jmalins commented Oct 1, 2022

Adds the acl package to the superchain image.

A recent projen PR added a build-time dependency on the getfacl and setfacl tools in this package to workaround a bug in GitHub Actions. The package is included in the GHA ubuntu-latest image, but not superchain.

Should address: projen/projen#2134


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmalins
Copy link
Contributor Author

jmalins commented Oct 1, 2022

Verified in local docker build that getfacl, setfacl are present.

@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2022

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Oct 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2022

Merging (with squash)...

@mergify mergify bot merged commit 306b248 into aws:main Oct 1, 2022
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants