Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add upgrade prompt at load of jsii and jsii-rosetta 1.x #4071

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

RomainMuller
Copy link
Contributor

This is to strongly incitate customers upgrade their dependencies, while trying to avoid alarming (there is 18 months left before the End-of-Support is scheduled, which is PLENTY of time).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is to strongly incitate customers upgrade their dependencies,
while trying to avoid alarming (there is 18 months left before the
End-of-Support is scheduled, which is PLENTY of time).
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 25, 2023
Copy link

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions seem so trivial that it does not make sense not to approve based on just that.

packages/jsii-rosetta/lib/upgrade-prompt.ts Outdated Show resolved Hide resolved
packages/jsii-rosetta/lib/upgrade-prompt.ts Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Apr 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2023

Merging (with squash)...

@mergify mergify bot merged commit 2cb15f8 into main Apr 26, 2023
@mergify mergify bot deleted the rmuller/maintenance-announcement branch April 26, 2023 09:11
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants