feat(superchain): switch to JDK 20 #4082
Merged
+28
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to a more recent version of the JDK. `jsii-pacmak` will keep on targeting Java 1.8, so this doesn't affect compatibility of the generated class files. What this will gain us is access to a more recent, optimized `javadoc` tool, which completes a lot faster than the one from JDK 8.
RomainMuller
previously requested changes
May 5, 2023
|
Confirmed that this builds javadocs On My Machine in a somewhat reasonable time, Still need to check that the pipeline docs build works with this version of Javadoc, which it looks like it might not |
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
kaizencc
approved these changes
May 12, 2023
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to a more recent version of the JDK.
jsii-pacmakwill keep on targeting Java 1.8, so this doesn't affect compatibility of the generated class files.What this will gain us is access to a more recent, optimized
javadoctool, which completes a lot faster than the one from JDK 8.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.