-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jsii-pacmak): escape documentation in all positions #4096
Merged
Commits on May 12, 2023
-
fix(jsii-pacmak): escape documentation in all positions
The [AWS::Personalize::Solution.PerformAutoML]( https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-personalize-solution.html#cfn-personalize-solution-performautoml) property immediately starts with an admonition, which in our system gets translated to: ``` /** * > Admonition! * * Normal description of the property */ ``` We weren't expecting complex markup in the 'summary' section of the JavaDocs, so we weren't escaping it, and this was making javadoc sad: ``` /software/amazon/awscdk/services/personalize/CfnSolution.java:2211: error: bad use of '>' * > We don't recommend enabling automated machine learning. ``` Be sure to properly do MarkDown -> HTML conversion everywhere.
Configuration menu - View commit details
-
Copy full SHA for 912dc42 - Browse repository at this point
Copy the full SHA 912dc42View commit details
Commits on May 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 280c082 - Browse repository at this point
Copy the full SHA 280c082View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c752d7 - Browse repository at this point
Copy the full SHA 8c752d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f8bb3f - Browse repository at this point
Copy the full SHA 8f8bb3fView commit details
Commits on May 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fd6f49d - Browse repository at this point
Copy the full SHA fd6f49dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c5344c - Browse repository at this point
Copy the full SHA 8c5344cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9b4944 - Browse repository at this point
Copy the full SHA a9b4944View commit details
Commits on May 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 79f8103 - Browse repository at this point
Copy the full SHA 79f8103View commit details -
Configuration menu - View commit details
-
Copy full SHA for 540bc51 - Browse repository at this point
Copy the full SHA 540bc51View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.