Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): register exported properties as callbacks #4104

Merged
merged 3 commits into from
May 16, 2023

Commits on May 15, 2023

  1. feat(go): register exported properties as callbacks

    When passing arbitrary structs through an `interface{}` type, the JS
    value had no properties or methods, leading to it having an empty object
    JSON representation.
    
    In order to improve the situation, discover exported properties of such
    structs, and register them as property callbacks, more closely matching
    the behavior of JS in the same configuration.
    
    The callbacks use the same naming transformation as the standard JSON
    serialization mechanism in go: using the `json` tag if present with the
    same semantics as `encoding/json`, and fall back to the raw field name
    otherwise (with no case conversion applied).
    
    Related: cdk8s-team/cdk8s#1326
    RomainMuller committed May 15, 2023
    Configuration menu
    Copy the full SHA
    0f7093e View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Configuration menu
    Copy the full SHA
    408a423 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82e607c View commit details
    Browse the repository at this point in the history