Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test for Node 20, set default to node 16 #4126

Merged
merged 23 commits into from
Jun 8, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
60b2911
chore: test for Node 20, set default to node 16
RomainMuller Jun 2, 2023
23a434c
Merge branch 'main' into rmuller/node-20
mergify[bot] Jun 2, 2023
c81467b
migrate off of set-outputs
RomainMuller Jun 2, 2023
7a765db
stop caching (hopefully this fixes running out of disk space
RomainMuller Jun 5, 2023
452b410
use Java 20 for integ tests
RomainMuller Jun 6, 2023
7993a02
increase max memory for running pacmak on aws-cdk-lib
RomainMuller Jun 6, 2023
e066b33
disable fail-fast for docker image matrix
RomainMuller Jun 6, 2023
59087f7
Merge branch 'main' into rmuller/node-20
RomainMuller Jun 7, 2023
6b18d96
try to tweak JVM options
RomainMuller Jun 7, 2023
d37d794
--no-parallel
RomainMuller Jun 7, 2023
5f70fb9
tweak some more
RomainMuller Jun 7, 2023
8ab0db9
tweak memory some further more
RomainMuller Jun 7, 2023
08cb8a3
undo JVM options, stick to no parallel
RomainMuller Jun 7, 2023
5679b88
Merge branch 'main' into rmuller/node-20
RomainMuller Jun 7, 2023
6176f38
give JVM up to 4G heap
RomainMuller Jun 8, 2023
31def9c
switch to corretto
RomainMuller Jun 8, 2023
5ea13f5
update maven POM dependencies, fork in maven
RomainMuller Jun 8, 2023
6478ccd
remove use of release (not supported by Java 8)
RomainMuller Jun 8, 2023
3592c2c
fixup jar plugin version
RomainMuller Jun 8, 2023
d844289
Simplify branch protection
RomainMuller Jun 8, 2023
ca60559
Merge branch 'main' into rmuller/node-20
RomainMuller Jun 8, 2023
fececbb
upgrade integ test environment fully
RomainMuller Jun 8, 2023
dea9dd7
Merge branch 'main' into rmuller/node-20
RomainMuller Jun 8, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: ['14', '16', '18']
node: ['14', '16', '18', '20']
env:
# Node version whose images will be aliased without the -nodeXX segment
DEFAULT_NODE_MAJOR_VERSION: 14
DEFAULT_NODE_MAJOR_VERSION: 16
steps:
- name: Check out
uses: actions/checkout@v3
Expand Down
36 changes: 18 additions & 18 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ jobs:
with:
distribution: 'zulu'
java-version: '8'
- name: Set up Node 14
- name: Set up Node 16
uses: actions/setup-node@v3
with:
cache: yarn
node-version: '14'
node-version: '16'
- name: Set up Python 3.7
uses: actions/setup-python@v4
with:
Expand Down Expand Up @@ -124,11 +124,11 @@ jobs:
with:
distribution: 'zulu'
java-version: '8'
- name: Set up Node 14
- name: Set up Node 16
uses: actions/setup-node@v3
with:
cache: yarn
node-version: '14'
node-version: '16'
- name: Set up Python 3.7
uses: actions/setup-python@v4
with:
Expand Down Expand Up @@ -194,7 +194,7 @@ jobs:
dotnet: ['6.0.x']
go: ['1.18']
java: ['8']
node: ['14'] # EOL 2023-04-30
node: ['16'] # EOL 2023-09-11
os: [ubuntu-latest]
python: ['3.7']
# Add specific combinations to be tested against "node 14" (to restrict cardinality)
Expand All @@ -205,15 +205,15 @@ jobs:
dotnet: '6.0.x'
go: '1.18'
java: '8'
node: '14'
node: '16'
python: '3.7'
# Test using macOS
- title: 'macOS'
os: macos-latest
dotnet: '6.0.x'
go: '1.18'
java: '8'
node: '14'
node: '16'
python: '3.7'
# Test alternate Nodes
- title: 'Node 16'
Expand All @@ -230,35 +230,35 @@ jobs:
node: '18' # EOL 2025-04-30
os: ubuntu-latest
python: '3.7'
- title: 'Node 19'
- title: 'Node 20'
java: '8'
dotnet: '6.0.x'
go: '1.18'
node: '19' # EOL 2023-06-01
node: '20' # EOL 2026-04-30
os: ubuntu-latest
python: '3.7'
# Test alternate .NETs
- title: '.NET 7.0'
java: '8'
dotnet: '7.0.x'
go: '1.18'
node: '14'
node: '16'
os: ubuntu-latest
python: '3.7'
# Test alternate Gos
- title: 'Go 1.19'
java: '8'
dotnet: '6.0.x'
go: '1.19'
node: '14'
node: '16'
os: ubuntu-latest
python: '3.7'
# Test alternate Javas
- title: 'Java 11'
java: '11'
dotnet: '6.0.x'
go: '1.18'
node: '14'
node: '16'
os: ubuntu-latest
python: '3.7'
# Test alternate Pythons
Expand All @@ -267,28 +267,28 @@ jobs:
dotnet: '6.0.x'
go: '1.18'
java: '8'
node: '14'
node: '16'
os: ubuntu-latest
- title: 'Python 3.9'
python: '3.9'
dotnet: '6.0.x'
go: '1.18'
java: '8'
node: '14'
node: '16'
os: ubuntu-latest
- title: 'Python 3.10'
python: '3.10'
dotnet: '6.0.x'
go: '1.18'
java: '8'
node: '14'
node: '16'
os: ubuntu-latest
- title: 'Python 3.11'
python: '3.11'
dotnet: '6.0.x'
go: '1.18'
java: '8'
node: '14'
node: '16'
os: ubuntu-latest

runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -440,10 +440,10 @@ jobs:
with:
distribution: 'zulu'
java-version: '8'
- name: Set up Node 14
- name: Set up Node 16
uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
- name: Set up Python 3.7
uses: actions/setup-python@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion packages/@fixtures/jsii-calc-bundled/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"directory": "packages/@fixtures/jsii-calc-bundled"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "index.js"
}
2 changes: 1 addition & 1 deletion packages/@jsii/check-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"directory": "packages/@jsii/check-node"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
12 changes: 6 additions & 6 deletions packages/@jsii/check-node/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,18 @@ export class NodeRelease {

// Past end-of-life releases
new NodeRelease(13, { endOfLife: new Date('2020-06-01') }),
new NodeRelease(14, {
endOfLife: new Date('2023-04-30'),
supportedRange: '^14.17.0',
}),
new NodeRelease(15, { endOfLife: new Date('2021-06-01') }),
new NodeRelease(12, {
endOfLife: new Date('2022-04-30'),
supportedRange: '^12.7.0',
}),
new NodeRelease(19, { endOfLife: new Date('2023-06-01') }),

// Currently active releases (as of last edit to this file...)
new NodeRelease(14, {
endOfLife: new Date('2023-04-30'),
supportedRange: '^14.6.0',
}),
new NodeRelease(16, {
endOfLife: new Date('2023-09-11'),
supportedRange: '^16.3.0',
Expand All @@ -46,10 +47,9 @@ export class NodeRelease {
supportedRange: '^17.3.0',
}),
new NodeRelease(18, { endOfLife: new Date('2025-04-30') }),
new NodeRelease(19, { endOfLife: new Date('2023-06-01') }),
new NodeRelease(20, { endOfLife: new Date('2026-04-30') }),

// Future (planned releases)
new NodeRelease(20, { endOfLife: new Date('2026-04-30'), untested: true }),
];

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/@jsii/dotnet-runtime-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"directory": "packages/@jsii/dotnet-runtime-test"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/@jsii/dotnet-runtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"directory": "packages/@jsii/dotnet-runtime"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/@jsii/java-runtime-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"directory": "packages/@jsii/java-runtime-test"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/@jsii/java-runtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"directory": "packages/@jsii/java-runtime"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/@jsii/kernel/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"directory": "packages/@jsii/kernel"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/@jsii/python-runtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"directory": "packages/@jsii/python-runtime"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/@jsii/runtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"directory": "packages/@jsii/runtime"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/@jsii/spec/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"directory": "packages/@jsii/spec"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/@scope/jsii-calc-base-of-base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"directory": "packages/@scope/jsii-calc-base-of-base"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "build/lib/index.js",
"types": "build/lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/@scope/jsii-calc-base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"directory": "packages/@scope/jsii-calc-base"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/@scope/jsii-calc-lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"directory": "packages/@scope/jsii-calc-lib"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "build/index.js",
"types": "build/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/codemaker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"directory": "packages/codemaker"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii-calc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"test"
],
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii-diff/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"directory": "packages/jsii-diff"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"bin": {
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii-pacmak/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"directory": "packages/jsii-pacmak"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii-reflect/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"directory": "packages/jsii-reflect"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii-rosetta/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"directory": "packages/jsii-rosetta"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"publishConfig": {
"tag": "v1"
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"directory": "packages/jsii"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/oo-ascii-tree/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"directory": "packages/oo-ascii-tree"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion tools/jsii-build-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"directory": "tools/jsii-build-tools"
},
"engines": {
"node": ">= 14.6.0"
"node": ">= 14.17.0"
},
"bin": {
"diff-test": "bin/diff-test",
Expand Down