Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii): Prohibit illegal uses of structs (aka data types) #418

Merged
merged 4 commits into from
Apr 2, 2019

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Apr 1, 2019

Expected failure cases:

  • An interface extending another one which is not a struct, cannot be a struct.
  • A class may not implement a struct interface
  • A regular interface may not implement a struct

Fixes #287


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RomainMuller RomainMuller self-assigned this Apr 1, 2019
@RomainMuller RomainMuller changed the title chore: Add negative test cases for illegal extendsions/implementations of data types fix(jsii): Prohibit illegal uses of structs (aka data types) Apr 1, 2019
@RomainMuller RomainMuller marked this pull request as ready for review April 1, 2019 13:48
@RomainMuller RomainMuller requested a review from a team as a code owner April 1, 2019 13:48
@RomainMuller RomainMuller merged commit 8ff9137 into master Apr 2, 2019
@RomainMuller RomainMuller deleted the rmuller/fix-datatypes branch April 2, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants