fix(dotnet): add missing GetInterfaceType in the .NET runtime #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
changed the title
packages/jsii-dotnet-runtime/src/Amazon.JSII.Runtime/Services/TypeCache.cs
Show resolved
Hide resolved
RomainMuller
force-pushed
the
hamzaad/2362
branch
from
88b585c to
99702d1
Compare
RomainMuller
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for return type being array of interfaces.
Tested with the customer code.
https://docs.aws.amazon.com/cdk/api/latest/dotnet/api/Amazon.CDK.AWS.EC2.Vpc.html#Amazon_CDK_AWS_EC2_Vpc_PrivateSubnets
This was not supported by the runtime, as it only allowed for classes and enums:
Fixes aws/aws-cdk#2362
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.