Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kernel): cannot pass decorated structs to kernel as "any" #997

Merged
merged 5 commits into from
Nov 18, 2019
Merged

fix(kernel): cannot pass decorated structs to kernel as "any" #997

merged 5 commits into from
Nov 18, 2019

Commits on Nov 18, 2019

  1. fix(kernel): cannot pass decorated structs as "any" 

    When a struct is serialized with a $jsii.struct decoration from a jsii host language and passed into a value typed `any`, the kernel ignored the decoration. This resulted in a malformed object passed to the javascript code.

This fix undecorates the object and continues to deserialize it as `any`.

Fixes aws/aws-cdk#5066
    Elad Ben-Israel committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    684a368 View commit details
    Browse the repository at this point in the history

  2. use fqn from struct decoration and delegate to struct deserializer

    Elad Ben-Israel committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    ee79e7b View commit details
    Browse the repository at this point in the history

  3. increase coverage for any ser/deser

    Elad Ben-Israel committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    e8ae5f9 View commit details
    Browse the repository at this point in the history

  4. update expectations

    Elad Ben-Israel committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    bf3d568 View commit details
    Browse the repository at this point in the history

  5. fix eslint issues

    Elad Ben-Israel committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    4bccda0 View commit details
    Browse the repository at this point in the history