Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias version pin is dropped when storage version is v1beta1 #6776

Closed
jmdeal opened this issue Aug 15, 2024 · 0 comments · Fixed by #6777
Closed

Alias version pin is dropped when storage version is v1beta1 #6776

jmdeal opened this issue Aug 15, 2024 · 0 comments · Fixed by #6777
Labels
bug Something isn't working triage/accepted Indicates that the issue has been accepted as a valid issue

Comments

@jmdeal
Copy link
Contributor

jmdeal commented Aug 15, 2024

Description

Observed Behavior:
When the storage version is v1beta1, the version pin for an alias on a v1 NodePool is dropped. In practice this shouldn't be problematic since version pinning for discovered AMIs isn't supported until v1.0.0 (at which point v1 is the storage version), but this behavior is surprising.

Expected Behavior:
Users should be able to set a version pin on the v1 resource, even when the storage version is v1beta1.

Versions:

  • Chart Version: 1.0.0
  • Kubernetes Version (kubectl version): 1.30
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@jmdeal jmdeal added bug Something isn't working needs-triage Issues that need to be triaged triage/accepted Indicates that the issue has been accepted as a valid issue and removed needs-triage Issues that need to be triaged labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates that the issue has been accepted as a valid issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant