Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Round up when launching a node with block device mappings #3330

Merged

Conversation

jonathan-innis
Copy link
Contributor

Fixes #3302

Description

  • Round up when launching a node with block device mappings
  • Include the blockDeviceMapping volumeSize requests in the hashing to notice a change in the volume size

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 31, 2023 19:36
@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 22117dc
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/63d977826dc70d00095145b4

@jonathan-innis jonathan-innis force-pushed the small-block-device-mapping-fix branch from df475ec to 080637e Compare January 31, 2023 19:45
@jonathan-innis jonathan-innis changed the title Round up when launching a node with block device mappings bug: Round up when launching a node with block device mappings Jan 31, 2023
@jonathan-innis jonathan-innis changed the title bug: Round up when launching a node with block device mappings fix: Round up when launching a node with block device mappings Jan 31, 2023
engedaam
engedaam previously approved these changes Jan 31, 2023
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis force-pushed the small-block-device-mapping-fix branch from cba928b to 22117dc Compare January 31, 2023 20:18
@jonathan-innis jonathan-innis enabled auto-merge (squash) January 31, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume of size 1GB is smaller than snapshot
2 participants