Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cherry-pick to v0.34.x): Include volumeSize, kubeReserved, and systemReserved in Instancetype hash calculations #5830

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner March 11, 2024 18:26
@engedaam engedaam requested a review from ellistarn March 11, 2024 18:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8237919463

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 82.543%

Totals Coverage Status
Change from base Build 8207644895: 0.07%
Covered Lines: 5031
Relevant Lines: 6095

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit e941ad6 into aws:release-v0.34.x Mar 11, 2024
12 checks passed
@engedaam engedaam deleted the instance-type-fix-0.34 branch March 11, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants