Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: run docgen and correct hyperlink #6750

Merged
merged 2 commits into from
Aug 14, 2024
Merged

docs: run docgen and correct hyperlink #6750

merged 2 commits into from
Aug 14, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Aug 14, 2024

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner August 14, 2024 18:34
@rschalo rschalo requested a review from bwagner5 August 14, 2024 18:34
@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit fd723a5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66bcf91f3cd359000892e0da
😎 Deploy Preview https://deploy-preview-6750--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

njtran
njtran approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rschalo rschalo enabled auto-merge (squash) August 14, 2024 18:36
@coveralls
Copy link

coveralls commented Aug 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10393115741

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 79.327%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 10393101183: -0.03%
Covered Lines: 5921
Relevant Lines: 7464
💛 - Coveralls

@rschalo rschalo merged commit 0e3a137 into aws:main Aug 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rschalo @coveralls @njtran