Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove Post Install Hook #6827

Merged
merged 4 commits into from
Aug 21, 2024
Merged

chore: Remove Post Install Hook #6827

merged 4 commits into from
Aug 21, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Aug 21, 2024 •
edited
Loading

Fixes #N/A

Description

  • Remove post install hook, and require karpenter users to use the karpenter-crd helm chart to configure the the conversion webhooks on the Karpenter CRDs

How was this change tested?

  • Manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify Netlify
Copy link

netlify bot commented Aug 21, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 6133e08
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66c6666629108300088e77e7

@coveralls
Copy link

coveralls commented Aug 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10498252516

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.311%
Totals Coverage Status
Change from base Build 10497921621: 0.0%
Covered Lines: 5938
Relevant Lines: 7487
💛 - Coveralls

@engedaam engedaam marked this pull request as ready for review August 21, 2024 21:04
@engedaam engedaam requested a review from a team as a code owner August 21, 2024 21:04
jonathan-innis
jonathan-innis approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 75d482f into aws:main Aug 21, 2024
16 checks passed
@engedaam engedaam deleted the remove-post-install-hook branch August 21, 2024 22:26
engedaam added a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@engedaam
chore: Remove Post Install Hook (aws#6827)
cd3a4ef
engedaam added a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@engedaam
chore: Remove Post Install Hook (aws#6827)
92c72b0
engedaam added a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@engedaam
chore: Remove Post Install Hook (aws#6827)
fc765fc
engedaam added a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@engedaam
chore: Remove Post Install Hook (aws#6827)
6e0ab63
engedaam added a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@engedaam
chore: Remove Post Install Hook (aws#6827)
0e06ed1
This was referenced Aug 22, 2024
Merged
Merged
Merged
Merged
Merged
engedaam added a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@engedaam
chore: Remove Post Install Hook (aws#6827)
149aeee
@engedaam engedaam mentioned this pull request Aug 22, 2024
Merged
3 tasks
jonathan-innis pushed a commit that referenced this pull request Aug 22, 2024
@engedaam
(backport) chore: Remove Post Install Hook (#6827) for v0.37.x (#6836)
e0d0f0c
jonathan-innis pushed a commit that referenced this pull request Aug 22, 2024
@engedaam
(backport) chore: Remove Post Install Hook (#6827) for v0.33.x (#6834)
d9873ba
jonathan-innis pushed a commit that referenced this pull request Aug 22, 2024
@engedaam
(backport) chore: Remove Post Install Hook (#6827) for v0.34.x (#6833)
152bfd8
jonathan-innis pushed a commit that referenced this pull request Aug 22, 2024
@engedaam
(backport) chore: Remove Post Install Hook (#6827) for v0.35.x (#6832)
384e851
@msvechla msvechla mentioned this pull request Aug 22, 2024
Closed
jonathan-innis added a commit that referenced this pull request Aug 22, 2024
@engedaam @jonathan-innis
(backport) chore: Remove Post Install Hook (#6827) for v0.36.x (#6835)
be20b0d 
Co-authored-by: Jonathan Innis <joinnis@amazon.com>
engedaam added a commit that referenced this pull request Aug 22, 2024
@engedaam
(backport) chore: Remove Post Install Hook (#6827) for v1.0.x (#6837)
365113f
@danielloader danielloader mentioned this pull request Aug 22, 2024
Closed
@engedaam engedaam mentioned this pull request Aug 23, 2024
Closed
@marcofranssen marcofranssen mentioned this pull request Aug 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jigisha620 jigisha620 Awaiting requested review from jigisha620 jigisha620 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jonathan-innis