Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Alow service namespace override #6849

Merged
merged 1 commit into from
Aug 22, 2024
Merged

chore: Alow service namespace override #6849

merged 1 commit into from
Aug 22, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Allow webhook.serviceNamespace override in conversion block

How was this change tested?

`helm upgrade --install karpenter-crd ./charts/karpenter-crd

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner August 22, 2024 22:37
@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 21c747d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66c7bfb4a37cbf0008c7ec2a

@jonathan-innis jonathan-innis enabled auto-merge (squash) August 22, 2024 22:38
@jonathan-innis jonathan-innis force-pushed the allow-service-namespace-override branch 2 times, most recently from 0189403 to 1fa79bf Compare August 22, 2024 22:40
@jonathan-innis jonathan-innis force-pushed the allow-service-namespace-override branch from 1fa79bf to 21c747d Compare August 22, 2024 22:46
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10516712017

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.324%
Totals Coverage Status
Change from base Build 10512499139: 0.01%
Covered Lines: 5939
Relevant Lines: 7487
💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10516689382

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.311%
Totals Coverage Status
Change from base Build 10512499139: 0.0%
Covered Lines: 5938
Relevant Lines: 7487
💛 - Coveralls

jmdeal
jmdeal approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 9939a34 into aws:main Aug 22, 2024
16 checks passed
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (aws#6849)
3026ff3
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (aws#6849)
9f0c507
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (aws#6849)
9ccb0db
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (aws#6849)
e577748
This was referenced Aug 22, 2024
Merged
Merged
Merged
Merged
Merged
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (aws#6849)
d950585
@engedaam engedaam mentioned this pull request Aug 22, 2024
Merged
3 tasks
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (aws#6849)
ea26874
engedaam pushed a commit that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (#6849)
a723318
engedaam pushed a commit that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (#6849)
d6b613a
engedaam pushed a commit that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (#6849)
62a726c
engedaam pushed a commit that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (#6849)
9a34671
engedaam pushed a commit that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (#6849)
e54ccdd
engedaam pushed a commit that referenced this pull request Aug 22, 2024
@jonathan-innis @engedaam
chore: Alow service namespace override (#6849)
6e9d95f
@dstrants dstrants mentioned this pull request Aug 26, 2024
Closed
@frimik frimik mentioned this pull request Sep 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @jmdeal