Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix webhook owner reference causing ArgoCD leak #7080

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Sep 26, 2024

Fixes #N/A

Description

Adds changes detailed in kubernetes-sigs/karpenter#1716 into the Provider Repo. This ensures that we both don't add and remove existing owner references from our webhook configuration objects so that we don't leak the objects when applying them with Argo.

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-ec5922bb7b2572f899747f7691269dedd9bd6c94.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-ec5922bb7b2572f899747f7691269dedd9bd6c94" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

coveralls commented Sep 26, 2024

Pull Request Test Coverage Report for Build 11135270005

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 78.678%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/webhooks/webhooks.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11079100066: -0.03%
Covered Lines: 5893
Relevant Lines: 7490

💛 - Coveralls

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-3a2df650cdf45ec6a8c464e1b777aeffa554b2f3.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-3a2df650cdf45ec6a8c464e1b777aeffa554b2f3" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jonathan-innis jonathan-innis force-pushed the fix-webhook-owner-ref branch 2 times, most recently from 2d1f36e to 68a9073 Compare October 1, 2024 23:47
@jonathan-innis jonathan-innis marked this pull request as ready for review October 1, 2024 23:47
@jonathan-innis jonathan-innis requested a review from a team as a code owner October 1, 2024 23:47
@jonathan-innis jonathan-innis merged commit 780ca37 into aws:release-v0.37.x Oct 2, 2024
13 checks passed
@jonathan-innis jonathan-innis deleted the fix-webhook-owner-ref branch October 2, 2024 05:47
jonathan-innis added a commit to jonathan-innis/karpenter-provider-aws that referenced this pull request Oct 2, 2024
jonathan-innis added a commit to jonathan-innis/karpenter-provider-aws that referenced this pull request Oct 2, 2024
jonathan-innis added a commit to jonathan-innis/karpenter-provider-aws that referenced this pull request Oct 2, 2024
jonathan-innis added a commit to jonathan-innis/karpenter-provider-aws that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants