-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix webhook owner reference causing ArgoCD leak #7080
fix: Fix webhook owner reference causing ArgoCD leak #7080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
Pull Request Test Coverage Report for Build 11135270005Details
💛 - Coveralls |
ec5922b
to
3a2df65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
2d1f36e
to
68a9073
Compare
68a9073
to
95e07c6
Compare
Fixes #N/A
Description
Adds changes detailed in kubernetes-sigs/karpenter#1716 into the Provider Repo. This ensures that we both don't add and remove existing owner references from our webhook configuration objects so that we don't leak the objects when applying them with Argo.
How was this change tested?
make presubmit
/karpenter snapshot
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.