fix: explicit check for initializationOptions and add optional chaining #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francescoopiccoli
approved these changes
Jan 28, 2025
volodkevych
reviewed
Jan 28, 2025
|
|
||
| return initializeResult | ||
| } catch (error) { | ||
| if (!params.initializationOptions?.aws) { |
There was a problem hiding this comment.
Can we make this field optional in protocol? Check comments in the previous PR.
There was a problem hiding this comment.
Ack, updated PR.
volodkevych
approved these changes
Jan 28, 2025
awschristou
reviewed
Jan 28, 2025
|
|
||
| return initializeResult | ||
| } catch (error) { | ||
| this.lspConnection.console.log( |
There was a problem hiding this comment.
The mitigation change added in this PR is not mutually exclusive with the observability change that has now been removed. Why can't we keep the try/catch handling in place? This way if an unexpected error happens in the future, we will have more information at our disposal to help investigate the situation.
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Check related PRs #306 and #307
Prevent errors due to aws object being undefined and improve error handling in initialize method
Solution
awsobject is not set.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.