Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added patches for markdown and unsafe-eval #225

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

aderende
Copy link
Contributor

@aderende aderende commented May 2, 2024

Problem

  • we do not want to show footer and header in hover content
  • ajv compile require unsafe-eval rule to be enabled. We can't enable this rule.

Solution

Added patches for markdown hover result and removed ajv usage.

Testing

ran npm install && npm run test
checked in browser that unsafe-eval is not required after applying the patch

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aderende aderende requested review from a team as code owners May 2, 2024 15:09
@justinmk3
Copy link
Contributor

How will other developers understand what's going on here, and how to maintain it? Is it documented somewhere?

@aderende
Copy link
Contributor Author

aderende commented May 6, 2024

How will other developers understand what's going on here, and how to maintain it? Is it documented somewhere?

Sure, it's a good idea. This patch is suppose to be temporary, because we work on merging the same changes to the red-hat package. I'll add the information to read.me and to the yaml-common package

@aderende aderende merged commit 7801265 into aws:main May 7, 2024
2 checks passed
@aderende aderende deleted the patch_server branch May 7, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants