Remove @smithy/abort-controller to fix browser builds #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makenneth
changed the title
makenneth
changed the title
volodkevych
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Browser build of qChatServer gets error in runtime in making Q api calls:
TypeError: Failed to construct 'Request': Failed to read the 'signal' property from 'RequestInit': Failed to convert value to 'AbortSignal'.According to this issue, aws/aws-sdk-js-v3#4582, we should use browser's nativeAbortController.Solution
Browsers have full support for
AbortControllerfor a while andAbortControllerhas been part of Node since v15.0.0. So we shouldn't need to install this that package at all.aws-sdk-v3, which the streaming client uses under the hood, does not support 14.x anymore so we can just to remove@smithy/abort-controllerLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.