chore: change release-please manifest to fix false major version bumps #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francescoopiccoli
approved these changes
Jan 14, 2025
natdurlik
reviewed
Jan 14, 2025
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "bootstrap-sha": "30ec14a11a4f9544d6b36a0196097b4425670937", | |||
| "bootstrap-sha": "ea570718da2b32b552b4308de1b4b3c2ee444b2b", | |||
There was a problem hiding this comment.
what we will do with changes made before this commit that should be included in release changelog?
There was a problem hiding this comment.
I don't think there are any, looking at the open release-pleae PR we have the following in the release notes and both of those commits come after the new bootstrap commit
Bug Fixes
make proxy nodejs only (#716) (37cf726)
Performance Improvements
dispose chat controller in chatController tests (#717) (b0e6b78)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the empty commits we made last week, release please now tries to make a version bump on every subpackage.
By changing the inception commit of release-please I am aiming to fix the wrong release created by release please and have release please only release actually changed subpackages.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.