Revert "feat: bugfix for artifacts upload (#749)" #766
+17
−59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some changes with PR #749 introduced delays in writing codeFiles list to requirements.json
We do not need codeFiles from requirements.json for transformation job but it is needed for summary generation.
On IDE, this summary is parsed to update counts, diffs for file changes
Solution
This reverts commit 71c0a19.
Test
Verified that after reverting this commit, we could get successfully .bak files in view diff screen
![image](https://private-user-images.githubusercontent.com/21162984/408740516-b28d40a8-37b8-40d6-80b0-4ef526855deb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NDg3MDcsIm5iZiI6MTczOTU0ODQwNywicGF0aCI6Ii8yMTE2Mjk4NC80MDg3NDA1MTYtYjI4ZDQwYTgtMzdiOC00MGQ2LTgwYjAtNGVmNTI2ODU1ZGViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE1NTMyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUxNTRmMGVkZjYxOGU1ZDBhMjMyNjBiOTlmNzVlNmI3MWZiMTQ1M2M5M2U5MjE3YjdjZDRkY2QyMjA5NTcyODcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.a97owFY7OvNWVkELQ8faoBqlDQrVLRfDTbPpyC_hk3w)
failing test CI job does not seem to be connected with nettransform. will connect with flare team for more guidance on it.
when I run
npm run test
locally, gave me all successful executionsfailing test is already failing with mainline commit - https://github.com/aws/language-servers/actions/runs/13075234433/job/36485706871
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.