Skip to content

chore: Make integ test run also on synchronize and opened in pull requests#125

Closed
arangatang wants to merge 1 commit intoaws:mainfrom
arangatang:arangatang-patch-1
Closed

chore: Make integ test run also on synchronize and opened in pull requests#125
arangatang wants to merge 1 commit intoaws:mainfrom
arangatang:arangatang-patch-1

Conversation

@arangatang
Copy link
Contributor

@arangatang arangatang commented Dec 10, 2025

Summary

Changes

Integ tests are now also executed if code is pushed to a pr and not only on the initial ready for review event.

User experience

  • Developers won't have to move from draft to ready to trigger the integ tests
  • Integ tests will have to pass before the PR can be merged.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)

  • Yes
  • No

Please add details about how this change was tested.

  • Did integration tests succeed?
  • If the feature is a new use case, is it necessary to add a new integration test case?

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…uests

Signed-off-by: Leonardo Araneda Freccero <arangatang@users.noreply.github.com>
@arangatang arangatang requested a review from a team as a code owner December 10, 2025 15:18
@arangatang arangatang enabled auto-merge (squash) December 10, 2025 15:19
@arangatang arangatang self-assigned this Dec 10, 2025
@arangatang
Copy link
Contributor Author

Integ tests are currently failing. Not related to this PR.

@arangatang
Copy link
Contributor Author

Hmm, there seem to be security issues with on: pull_request in terms of repository secrets.
Github blogpost about this here: https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/
This needs some more work, will move this to draft.

@arangatang arangatang marked this pull request as draft December 12, 2025 09:23
@arangatang arangatang closed this Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant