Skip to content

Commit

Permalink
ci: require more interop tests to pass (#1919)
Browse files Browse the repository at this point in the history
* ci: require more interop tests to pass

* add newline

* fix whitespace

* remove handshakeloss and corruption, fix handling of PR report

* remove kwik

* remove rebind address

* patch rebind addr test

* increase timeout limits and disable MTU probing to increase chance of HandshakeLoss/Corruption tests succeeding

* remove msquic as it always fails everything and takes a long time
  • Loading branch information
WesleyRosenblum authored Aug 24, 2023
1 parent d67267d commit 7016e9c
Show file tree
Hide file tree
Showing 6 changed files with 396 additions and 119 deletions.
16 changes: 12 additions & 4 deletions .github/interop/check.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,20 @@ def format_required_report(report):
outcome.setdefault(test['name'], {})

info = outcome[test['name']]
info.setdefault(client, {'client': False, 'server': False})
info.setdefault(server, {'client': False, 'server': False})
if client == s2n_quic and server == s2n_quic:
info.setdefault('s2n-quic', {})
else:
info.setdefault(client, {})
info.setdefault(server, {})

success = test['result'] == 'succeeded'
info[client]['client'] = success
info[server]['server'] = success
if client == s2n_quic and server == s2n_quic:
info['s2n-quic']['client'] = success
info['s2n-quic']['server'] = success
elif client == s2n_quic:
info[server]['server'] = success
else:
info[client]['client'] = success

return outcome

Expand Down
2 changes: 1 addition & 1 deletion .github/interop/required.check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ for commit in $COMMITS; do
fi

if [ -s $OUT_DIR/$commit.json ]; then
python .github/interop/check.py --required .github/interop/required.json $OUT_DIR/$commit.json
python3 .github/interop/check.py --required .github/interop/required.json $OUT_DIR/$commit.json
else
echo " report could not be found; skipping"
fi
Expand Down
Loading

0 comments on commit 7016e9c

Please sign in to comment.