fix(s2n-quic-transport): optimize STOP_SENDING state #1217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When entering the STOP_SENDING state in the receive stream, we currently wait for the peer to either finish transmitting all outstanding data or send a RESET frame. This isn't really needed since the application has already indicated that it's not going to read any more data.
This change, instead, marks the stream as finalized when the STOP_SENDING frame is ACKed. Any additional frames that are received will be ignored:
s2n-quic/quic/s2n-quic-transport/src/stream/stream_manager.rs
Lines 807 to 813 in 222a807
Testing:
I've updated all of the receive stream unit tests to reflect the new behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.