fix(s2n-quic-transport): bundle ACK frames with probes #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/ack-probes
branch
2 times, most recently
from
55e5b72
to
9384558
Compare
camshaft
force-pushed
the
camshaft/ack-probes
branch
from
9384558
to
06a5a81
Compare
toidiu
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, when we send probes the ACK manager will only transmit an ACK frame when it is in Active or Passive mode. This is suboptimal as we miss out on transmitting an ACK, which would allow the peer to recover more quickly from its own loss.
This change, instead looks at the transmission mode and, if it's a probe, will bundle an ACK frame with the packet. In testing, this showed to improve connection resiliency.
Testing:
I've updated the ACK transmission state tests with a snapshot of all of the possible inputs and outputs for
should_transmit. This should prevent a regression in this change.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.