test(s2n-quic-platform): refactor testing IO provider to use tasks/queues #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/io-queue-refactor
branch
3 times, most recently
from
9a4a7a7
to
2d95de4
Compare
camshaft
force-pushed
the
camshaft/io-queue-refactor
branch
from
2d95de4
to
2bc1cd5
Compare
WesleyRosenblum
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change refactors the testing IO provider a bit to use the same queues and tasks that the other IO providers use. This brings the implementations a lot closer to have a high fidelity simulation.
Call-outs:
While I was refactoring the network implementation, I added support for address rebinding. I've got another PR (#1874) that actually adds some tests around it.
Testing:
All of the existing integration tests should pass as before and show this refactor is working.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.