feat(dc): DcSupportedVersions transport parameter #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Apr 30, 2024
camshaft
reviewed
May 1, 2024
camshaft
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a
dc_supported_versionstransport parameter. This parameter is used by the client to indicate which versions ofs2n-quic-dcit supports and by the server to indicate which version it is using.Call-outs:
The server transport parameters are currently set on the TLS session before the client transport parameters are made available to the connection. This means that negotiating
s2n-quic-dcversions using transport parameters would not be possible, as the version the server selects is dependent on the versions the client provided in the transport parameter. To address this, the server transport parameters that the TLS session is created with are stored within the session as aVec<u8>. When the client transport parameters become available early in the handshake, they are provided to theSessionContextalong with theVec<u8>of server transport parameters. The connection is then allowed to append additional transport parameters to theVec<u8>.Testing:
Added some unit tests. More tests will be added once the parameter is used.
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed? -->
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.