ci: add ASAN to s2n-quic ci #2410
Merged
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boquan-fang
force-pushed
the
asan-check-in-ci
branch
2 times, most recently
from
6c1a4f5 to
656be98
Compare
camshaft
reviewed
Dec 10, 2024
boquan-fang
force-pushed
the
asan-check-in-ci
branch
from
a679233 to
93ad678
Compare
camshaft
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We want to run ASAN for the s2n-quic library. This change is inspired by aws/s2n-tls#4948.
I have added necessary env variables to the CI, and run it in s2n-quic's CI.
Call-outs:
We added
detect_leak=falseflag to the CI. We need to discuss whether we want to reenable that flag in the future.Testing:
This change will be tested by the github CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.