refactor(s2n-quic-dc): add control_frames fn to control packets #2543
+141
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boquan-fang
approved these changes
Mar 14, 2025
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| let header = &*self.header; | ||
|
|
||
| let mut s = f.debug_struct("control::Packet"); |
There was a problem hiding this comment.
nit: can we use a better variable name for s?
There was a problem hiding this comment.
generally I do avoid single letter variable names but TBH I'm never really sure what to call the debug structs so i always just use s :D
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/s2n-quic
that referenced
this pull request
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change moves the control frame parsing logic to the
control::decodermodule, instead of being done in the sender state. This makes it a bit easier to do ad-hoc debugging to get all of the frames.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.