Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds GSO for Linux. It passes the segment size through the cmsg(3) interface. A couple things to note:
EIO
error from the OS. I initially tried to probe justlocalhost
but that led to a false positive, which made all of the interop tests fail.transport
crate's perspective, basically nothing changed!can_gso
to thetx::Message
trait that tells the IO layer if it can be used as part of a segment.Overall these changes produce some good results. Here's the before/after of CPU usage to saturate a 1GbE:
Before
After
Here's the flamegraphs for the same test:
Before
After
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.