Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin dependencies after bumping MSRV beyond 1.65 #4242

Open
toidiu opened this issue Oct 11, 2023 · 1 comment
Open

Unpin dependencies after bumping MSRV beyond 1.65 #4242

toidiu opened this issue Oct 11, 2023 · 1 comment
Labels
MSRV s2n-core team

Comments

@toidiu
Copy link
Contributor

toidiu commented Oct 11, 2023 •
edited by dougch
Loading

Problem:

  • One of our dependencies of dependencies (regex) broke MSRV (requires 1.65) in >v1.9.6. To work around this, we have pinned this dependency to =1.9.6.
  • s2n-tls-hyper -> hyper -> h2 -> indexmap -> hashbrown =0.15.0 addressed in chore: move hyper to a newer MSRV #4983

Solution:

This should be reverted after bumping MSRV.
@toidiu toidiu mentioned this issue Oct 11, 2023
Merged
@goatgoose goatgoose added the MSRV label May 2, 2024
@dougch
Copy link
Contributor

dougch commented Dec 16, 2024

#4971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MSRV s2n-core team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@goatgoose @toidiu @dougch @WesleyRosenblum