-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move hyper to a newer MSRV #4983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you put the testing result in the Testing:
section in the PR description? I think that part is missing. I think it's helpful to ping test results for a PR involves structure changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing has been updated.
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
Co-authored-by: James Mayclin <maycj@amazon.com>
Co-authored-by: James Mayclin <maycj@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the followup list: I think we'll also want rustfmt and asan running in the standard workspace.
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
Release Summary:
Resolved issues:
#4971 and https://github.com/aws/s2n-tls/security/dependabot/1
Description of changes:
Due to hyper dependencies, move it out of our bindings workspace to allow for a newer Rust version and security updates.
Final directory structure, with a different MSRV for extneded, standard and rust-examples.
Call-outs:
This PR is going the refactor-all-the-things approach, many of the files are unchanged, but path depth is growing by one, across the board.
The regression test GHA will fail, because a path change breaks the flip back to the main branch, this will need an over-ride or a limited-time not required change.
Followups
Testing:
This PR is tested by Rust bindings CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.