Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FS2 Scala Native binding to binding list #3496

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Conversation

armanbilge
Copy link
Contributor

Description of changes:

Adds FS2 as a Scala Native binding to the list of external bindings.

Call-outs:

I'm a maintainer of the FS2 project 😅

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@armanbilge armanbilge requested a review from a team as a code owner September 15, 2022 14:48
Copy link
Contributor

@lrstewart lrstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! Thank you for doing this!

Would it be possible to mention that s2n-tls is your TLS implementation in your own documentation?

@armanbilge
Copy link
Contributor Author

Ah yes. I updated the get-started page with this info but I see I need to update the TLS docs as well.
https://fs2.io/#/getstarted/install

Thanks for the enthusiasm :)

@armanbilge
Copy link
Contributor Author

@lrstewart lrstewart merged commit 54896d7 into aws:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants