fix(bindings): pin jobserver in more places and run cargo publish --dry-run in generate.sh #4255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesleyRosenblum
requested review from
jmayclin,
camshaft and
maddeleine
and removed request for
camshaft
maddeleine
approved these changes
Oct 23, 2023
camshaft
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Similar to aws/s2n-quic#2009, when publishing the bindings to crates.io, the pinned jobserver dev-dependency in s2n-tls-sys was not respected, and the verification step failed. This change adds additional dev-dependency pins of jobserver to the s2n-tls and s2n-tls-tokio crates.
I've also modified the
generate.shscript to run a cargo publish --dry-run ons2n-tlsands2n-tls-tokioto catch this issue in CI. The publish does not run if the version number has been bumped, as it would fail when looking for the new version.Testing:
Tested locally
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.