Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove blinding from self_talk_sesion_id test #4281

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

jmayclin
Copy link
Contributor

@jmayclin jmayclin commented Nov 9, 2023

This test is currently the second slowest test because it trigger blinding twice. The commit set's blinding to self serve so the test takes 4 seconds to execute instead of 40.

Testing:

I added a print statement to s2n_connection_kill sleep logic, and confirmed that there were no print statements in all of our unit tests after I added these connection settings.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This test is currently the second slowest test because it trigger
blindings twice.
@jmayclin jmayclin requested review from lrstewart and dougch November 9, 2023 22:17
@github-actions github-actions bot added the s2n-core team label Nov 9, 2023
@jmayclin jmayclin marked this pull request as ready for review November 9, 2023 22:18
@jmayclin jmayclin enabled auto-merge (squash) November 9, 2023 23:06
Copy link
Contributor

@lrstewart lrstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably isn't the only test that still has this error. I've had to make this same change in other unit tests before :(

@jmayclin jmayclin merged commit 1b9b1d6 into aws:main Nov 10, 2023
24 checks passed
@jmayclin
Copy link
Contributor Author

jmayclin commented Nov 10, 2023

This probably isn't the only test that still has this error.

I think my little "printf if blinding sleep" test should have caught the low hanging ones, but if we're doing weird things with stdout there's definitely a chance that I missed some.

@jmayclin jmayclin deleted the no-blinding-unit-test branch June 15, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants