ci: ignore cbmc prereleases #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
reviewed
Dec 15, 2023
| @@ -62,7 +62,7 @@ jobs: | |||
| run: | | |||
| # Search within 5 most recent releases for latest available package | |||
| CBMC_REL="https://api.github.com/repos/diffblue/cbmc/releases?page=1&per_page=5" | |||
| CBMC_DEB=$(curl -s $CBMC_REL --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' | jq -r '.[].assets[].browser_download_url' | grep -e 'ubuntu-20.04' | head -n 1) | |||
| CBMC_DEB=$(curl -s $CBMC_REL --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' | jq -r '.[]|select(.prerelease|not).assets[].browser_download_url' | grep -e 'ubuntu-20.04' | head -n 1) | |||
There was a problem hiding this comment.
In #4329 I proposed to make even more use of jq. Just a suggestion.
There was a problem hiding this comment.
Personally I think the current version with grep + head is more readable. I don't mind the chaining, and jq can get pretty dense.
goatgoose
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Some of our CBMC proofs are currently failing with a python error from the CBMC viewer about missing goal descriptions: https://github.com/aws/s2n-tls/actions/runs/7215710149/job/19660493232
The issue seems to be the latest CBMC release: https://github.com/diffblue/cbmc/releases The latest release is a pre-release and even comes with a warning about not using it in production. However, the logic in our github action that queries for the latest CBMC release doesn't check the "prerelease" field in the response. I've updated it to ignore prereleases to avoid errors like this without needing to pin the version.
Call-outs:
I preemptively made the same change for litani. The other dependencies use tags to indicate what "latest" means.
Testing:
The CBMC proofs now pass, and you can see that version 5.59.1 is being chosen instead of 6.0.0 here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.