(feat): Adds API to allow s2n-quic to check for resumption #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
reviewed
Dec 19, 2023
lrstewart
reviewed
Dec 19, 2023
goatgoose
approved these changes
Dec 20, 2023
lrstewart
reviewed
Dec 21, 2023
maddeleine
force-pushed
the
resumption_check
branch
from
1988600 to
d0d106b
Compare
maddeleine
changed the title
lrstewart
reviewed
Dec 21, 2023
lrstewart
approved these changes
Dec 21, 2023
goatgoose
approved these changes
Dec 21, 2023
maddeleine
force-pushed
the
resumption_check
branch
from
8aeabe4 to
c55761c
Compare
dougch
pushed a commit
to dougch/s2n-tls
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds API to allow s2n-quic to check if it needs to keep around the TLS session instead of just tossing it after the handshake. Currently the TLS settings are mostly opaque to s2n-quic. However, if we want to keep the optimization of throwing out the TLS session when it isn't needed, quic needs to know if it should expect a session ticket.
Callouts:
Testing:
Does this need a test? I don't think so.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.