feat: More client hello getters #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
reviewed
Jan 29, 2024
lrstewart
reviewed
Jan 30, 2024
goatgoose
reviewed
Jan 31, 2024
maddeleine
force-pushed
the
client_getters
branch
from
805d4a0 to
9526a70
Compare
goatgoose
reviewed
Feb 1, 2024
lrstewart
reviewed
Feb 1, 2024
lrstewart
reviewed
Feb 2, 2024
goatgoose
approved these changes
Feb 3, 2024
lrstewart
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A
Description of changes:
Adds four new APIs. One to get the TLS version in the Client Hello record header, one to get the TLS version in the Client Hello, and two to get the compression methods list.
Call-outs:
Testing:
Includes tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.