Adding a harness for session resumption in regression test #4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
reviewed
Aug 15, 2024
Co-authored-by: maddeleine <59030281+maddeleine@users.noreply.github.com>
maddeleine
approved these changes
Aug 19, 2024
jmayclin
reviewed
Aug 20, 2024
tests/regression/src/lib.rs
Outdated
| #[test] | ||
| fn test_session_resumption() { | ||
| valgrind_test("test_session_resumption", 0.01, |ctrl| { | ||
| const KEY_NAME: &str = "InsecureTestKey"; |
There was a problem hiding this comment.
nit: I'd vote for moving the constants into the top level scope of the function.
tests/regression/src/lib.rs
Outdated
| .add_session_ticket_key( | ||
| KEY_NAME.as_bytes(), | ||
| KEY_VALUE.as_slice(), | ||
| SystemTime::now(), |
There was a problem hiding this comment.
Clock skew will cause this to sometimes be flaky, because the system clock will sometimes jump in time.
Suggested change
| SystemTime::now(), | |
| SystemTime::now() - Duration::from_secs(10), |
|
The regression test will fail since mainline doesn't have the session resumption test yet. Typically changes to solely the regression test will not trigger the test to run but since I changed the .gitignore file (exists outside the regression crate) in a recent commit, the test still runs on this PR. |
jmayclin
approved these changes
Aug 20, 2024
Co-authored-by: James Mayclin <maycj@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds a new regression test for measuring session resumption performance in the s2n-tls library. The test, test_session_resumption, performs an initial handshake without a session ticket and then attempts to resume the session using a session ticket in a subsequent handshake. The test is integrated with the valgrind_test function, allowing Cachegrind instrumentation to measure the performance of the session resumption process.
Call-outs:
pair.client.session_ticket()call is left out of the instrumentation measurement since that occurs in the first handshake.