-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add UBSAN test to the sanitizer #4740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include links to the failed codebuild jobs in your testing section?
lrstewart
added
the
do_not_merge
PR might needs something before merging, even if approved and passing
label
Aug 28, 2024
* Retain build changes.
lrstewart
approved these changes
Aug 28, 2024
jmayclin
approved these changes
Aug 28, 2024
dougch
approved these changes
Aug 28, 2024
boquan-fang
removed
the
do_not_merge
PR might needs something before merging, even if approved and passing
label
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves the second requirement #4684. This PR is also a alternative for PR#4734.
Description of changes:
buildspec_asan.yml
tobuildspec_sanitizer.yml
.-DUBSAN=ON
tobuildspec_sanitizer.yml
.Call-outs:
buildspec_sanitizer.yml
file as source.Testing:
Need to prove the one build commands with both
ASAN
andUBSAN
will still check for memory leak and undefined behavior.Link: https://us-west-2.console.aws.amazon.com/codesuite/codebuild/024603541914/projects/AddressSanitizer/batch/AddressSanitizer%3A9f488b1a-2ce9-463b-90b6-ea022fc90dfc?region=us-west-2
The build detects UBSAN violation.
DEFER_CLEANUP
Macro ins2n_record_size_test.c
. That should trigger memory leak.Link: https://us-west-2.console.aws.amazon.com/codesuite/codebuild/024603541914/projects/AddressSanitizer/batch/AddressSanitizer%3Ae38cdb87-26a6-4081-888a-faa0aed81dd1?region=us-west-2
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.