Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindings): unpin jobserver #4758

Merged
merged 3 commits into from
Sep 9, 2024
Merged

fix(bindings): unpin jobserver #4758

merged 3 commits into from
Sep 9, 2024

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Sep 9, 2024

Resolves:

#4241

Description of changes:

Our CI is failing due an api change in the cc crate. This PR updates the minimum dependencies to require a higher minimum-version of cc = "1.0.100". It also unpins jobserver since it looks like they fixed their MSRV to 1.63.

Testing:

All tests pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Sep 9, 2024
@toidiu toidiu marked this pull request as ready for review September 9, 2024 19:03
@camshaft camshaft changed the title fix: pin aws-lc-rs fix(bindings): unpin jobserver Sep 9, 2024
@dougch dougch self-requested a review September 9, 2024 19:06
@toidiu toidiu enabled auto-merge (squash) September 9, 2024 19:11
@toidiu toidiu merged commit 5cd8bc7 into aws:main Sep 9, 2024
36 checks passed
@toidiu toidiu deleted the ak-pin-awslcrs branch September 9, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants