feature: bump cert authorities max size to 20kb #4832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Bumping the cert authorities limit for a customer.
Call-outs:
The extensions are limited to a size of UINT16_MAX, so about 65K. The cert authorities have to share that size with the other extensions, so this max size leaves about 45K for other extensions. We currently only support the cert authorities extension on the certificate request message, which only also supports the signature algorithms and certificate status extensions, but could support more extensions in the future.
Testing:
Existing tests pass, including the test that verifies we can't load the default AL2012 trust store due to its size:
s2n-tls/tests/unit/s2n_cert_authorities_test.c
Lines 99 to 110 in 4a1bfee
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.