ci: Re-enable asan and ubsan for fuzz tests #4840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Asan and ubsan were disabled for fuzz testing due to memory issues in CI after transitioning from the Make build system to CMake. These sanitizers are critical for detecting memory-related issues, and re-enabling them will enhance fuzz coverage.
Memory issue reproduced in this CodeBuild job
The likely cause of the memory issues was not disabling MADV_DONTDUMP as required, which is documented here:
s2n-tls/utils/s2n_mem.c
Lines 103 to 112 in 5a2fdf6
This PR re-enables asan and ubsan for better test coverage.
Description of changes:
Add asan and ubsan option to fuzz tests, and add a compile definition for fuzz test to disable MAD_DONTDUMP
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.