ci: fixes for cargo audit #4895
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
approved these changes
Nov 14, 2024
goatgoose
reviewed
Nov 14, 2024
Comment on lines
+21
to
+23
| # Pin the nightly toolchain to prevent breakage. | ||
| # This should be occasionally updated. | ||
| RUST_NIGHTLY_TOOLCHAIN: nightly-2024-01-01 |
There was a problem hiding this comment.
Why do we need to configure a nightly toolchain? Aren't we using stable below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
none
Description of changes:
S2n-tls isn't a pure rust project, more work is required before running the
cargo auditaction.Call-outs:
Validated on main of my fork
Due to permissions issues, this action does not run in the PR workflow (hence the missed failure)
Testing:
How is this change tested: locally and in my fork
Cargo.lockin the root directory of the project.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.