Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): Fixes team-label github action #4935

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

maddeleine
Copy link
Contributor

@maddeleine maddeleine commented Nov 26, 2024

Release Summary:

N/A

Resolved issues:

N/A

Description of changes:

We need to use actual tags in our versions for various github actions. The parser is unfortunately not very sophisticated and doesn't know what v1.3 means since the maintainer only has a v1.3.0 tag.
See: https://github.com/orgs/community/discussions/48058

Call-outs:

N/A

Testing:

Note that the CI still fails because (confusingly) it isn't using my change yet.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@CarolYeh910 CarolYeh910 enabled auto-merge (squash) November 26, 2024 19:51
@CarolYeh910 CarolYeh910 disabled auto-merge November 26, 2024 19:51
@maddeleine maddeleine requested review from jmayclin and jouho November 26, 2024 20:10
@maddeleine maddeleine merged commit be2ad4b into aws:main Nov 27, 2024
38 checks passed
@maddeleine maddeleine deleted the team-label branch November 27, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants