Integv2 sslv2 #5019
Draft
Integv2 sslv2 #5019
+101
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
force-pushed
the
integv2-sslv2
branch
from
c379913 to
c632724
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import pytest | ||
|
|
||
| from configuration import available_ports | ||
| from common import Certificates, Ciphers, Curves, Protocols, ProviderOptions, data_bytes |
Check notice
Code scanning / CodeQL
Unused import Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Based on feedback from #5011 , this PR instead adds an SSLv2 integration using the
integrationv2style.Call-outs:
Risk: I am worried that Java might disable this behavior at some point in the future, and the test will silently switch back to using modern ClientHellos. If we want finer grained assertions, then we should go the route of #5011 .
Testing:
I examined the ClientHello with wireshark and added a debug statement to confirm that the ClientHello that the java client was sending was ClientHello SSLv2.
The IntegV2 CLI is in a very rough state, so I'm gonna have to make manual changes to the CI to get it to run. I'll probably just push out another PR committing the buildspec to code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.